From 5eedbe1f59c2f25cb1938492e530e5f0f377b4c1 Mon Sep 17 00:00:00 2001 From: Hollander_1908 <93162595+Hollander-1908@users.noreply.github.com> Date: Tue, 14 Mar 2023 12:56:34 +0100 Subject: [PATCH 1/2] DASH: improved forced subtitle recognition Some manifests uses value `forced_subtitle` instead of the regular `forced-subtitle`. This way both are recognized. --- devine/core/manifests/dash.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/devine/core/manifests/dash.py b/devine/core/manifests/dash.py index e63632a..6bb534d 100644 --- a/devine/core/manifests/dash.py +++ b/devine/core/manifests/dash.py @@ -124,7 +124,8 @@ class DASH: for x in adaptation_set.findall("Accessibility") ) forced = any( - (x.get("schemeIdUri"), x.get("value")) == ("urn:mpeg:dash:role:2011", "forced-subtitle") + x.get("schemeIdUri") == "urn:mpeg:dash:role:2011" + and x.get("value") in ("forced-subtitle", "forced_subtitle") for x in adaptation_set.findall("Role") ) cc = any( From cd2831fe82ec2869099ebc5bef7b2aa84361d226 Mon Sep 17 00:00:00 2001 From: rlaphoenix Date: Tue, 14 Mar 2023 12:39:05 +0000 Subject: [PATCH 2/2] Add Hollander-1908 to Contributors list --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index db9b75c..f3d0486 100644 --- a/README.md +++ b/README.md @@ -292,6 +292,7 @@ Please refrain from spam or asking for questions that infringe upon a Service's + ## License