From e7e18a42041ceaaa5e9c77e56793c2d0a85a7e62 Mon Sep 17 00:00:00 2001 From: rlaphoenix Date: Fri, 29 Dec 2023 16:03:49 +0000 Subject: [PATCH] Use same output subtitle format as input codec to SubtitleEdit calls --- devine/core/tracks/subtitle.py | 17 +++++++++++++++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/devine/core/tracks/subtitle.py b/devine/core/tracks/subtitle.py index a69a6e4..d7e4fbb 100644 --- a/devine/core/tracks/subtitle.py +++ b/devine/core/tracks/subtitle.py @@ -358,10 +358,16 @@ class Subtitle(Track): executable = get_binary_path("SubtitleEdit") if executable: + if self.codec == Subtitle.Codec.SubStationAlphav4: + output_format = "AdvancedSubStationAlpha" + elif self.codec == Subtitle.Codec.TimedTextMarkupLang: + output_format = "TimedText1.0" + else: + output_format = self.codec.name subprocess.run( [ executable, - "/Convert", self.path, "srt", + "/Convert", self.path, output_format, "/encoding:utf8", "/overwrite", "/RemoveTextForHI" @@ -393,10 +399,17 @@ class Subtitle(Track): if not executable: raise EnvironmentError("SubtitleEdit executable not found...") + if self.codec == Subtitle.Codec.SubStationAlphav4: + output_format = "AdvancedSubStationAlpha" + elif self.codec == Subtitle.Codec.TimedTextMarkupLang: + output_format = "TimedText1.0" + else: + output_format = self.codec.name + subprocess.run( [ executable, - "/Convert", self.path, "srt", + "/Convert", self.path, output_format, "/ReverseRtlStartEnd", "/encoding:utf8", "/overwrite"