From b631e4ed64f7d1b9ca8f897fda31140e8d1fad81 Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Sat, 14 Apr 2012 18:28:31 +0200 Subject: [PATCH] lagarith: check count before writing zeros. Fixes CVE-2012-2793 Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Anton Khirnov --- libavcodec/lagarith.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/libavcodec/lagarith.c b/libavcodec/lagarith.c index e365610410..a34c28941b 100644 --- a/libavcodec/lagarith.c +++ b/libavcodec/lagarith.c @@ -361,6 +361,11 @@ static int lag_decode_zero_run_line(LagarithContext *l, uint8_t *dst, output_zeros: if (l->zeros_rem) { count = FFMIN(l->zeros_rem, width - i); + if (end - dst < count) { + av_log(l->avctx, AV_LOG_ERROR, "Too many zeros remaining.\n"); + return AVERROR_INVALIDDATA; + } + memset(dst, 0, count); l->zeros_rem -= count; dst += count;