From de4cd8b59b52ba68a00e8d74dfbc1a53db21a3c2 Mon Sep 17 00:00:00 2001 From: Tatsuhiro Tsujikawa Date: Wed, 19 Feb 2014 21:34:20 +0900 Subject: [PATCH] Warn if neither --rpc-secret nor a combination of --rpc-user/rpc-passwd is set --- src/DownloadEngineFactory.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/DownloadEngineFactory.cc b/src/DownloadEngineFactory.cc index 1dd6aaa3..39b04f98 100644 --- a/src/DownloadEngineFactory.cc +++ b/src/DownloadEngineFactory.cc @@ -196,6 +196,12 @@ DownloadEngineFactory::newDownloadEngine e.get(), pid)); } if(op->getAsBool(PREF_ENABLE_RPC)) { + if(op->get(PREF_RPC_SECRET).empty() && op->get(PREF_RPC_USER).empty()) { + A2_LOG_WARN("Neither --rpc-secret nor a combination of --rpc-user and " + "--rpc-passwd is set. This is insecure. It is extremely " + "recommended to specify --rpc-secret with the adequate " + "secrecy or now deprecated --rpc-user and --rpc-passwd."); + } bool ok = false; bool secure = op->getAsBool(PREF_RPC_SECURE); if(secure) {