Commit Graph

2253 Commits

Author SHA1 Message Date
thealphadollar
68e6f2616d Update instructions to install with HardSubx
Currently the instructions to install with hardsubx are vague and a new method was added in PR #966
This method makes installation with HARDSUBX easy and hence has been added to the documentation.
2018-05-15 12:39:23 +05:30
thealphadollar
d0d8529afa [FIX] Remove instance of o1 and o2 from help
There are no parameters as o1 or o2 in ccextractor but they have been mentioned in the help.

This commit removes such instances from file(s).

Change severity: trivial
2018-05-06 20:13:53 +05:30
Chris Lamb
b36429879d Make the build reproducible (#976)
Whilst working on the Reproducible Builds effort [0], we noticed
that ccextractor could not be built reproducibly.

This is due to it including the current date.

This was originally filed in Debian as #896867 [1] and uses the
SOURCE_DATE_EPOCH environment variable [2].

 [0] https://reproducible-builds.org/
 [1] https://bugs.debian.org/896867
 [2] https://reproducible-builds.org/specs/source-date-epoch/

Signed-off-by: Chris Lamb <lamby@debian.org>
2018-04-25 11:17:50 -07:00
Shivam Kumar Jha
c7bc2b78ac [IMPROVEMENT] Update libGPAC (#974)
* Add Updated GPAC

File changes have been directly inserted from libGPAC master into ccextractor's libGPAC.

This has resulted into removal of multiple custom functions and minor changes. These will be rectified in the next step of the updation.

Change severity: Very High

* Update libGPAC dependency

We use libGPAC for all our MP4 operations and, this commit updates it to the latest version.

All previous changes to the original library were restored post straight file updation and bugs have been removed.

change severity: very high

* Add Guide To Updating Dependencies

A small textual guide on how to update dependencies easily and efficiently.
2018-04-23 11:24:03 -07:00
Carlos Fernandez
1afe08af08 Extra line 2018-04-23 11:22:32 -07:00
Carlos Fernandez
52707267fc linux/builddebug: Added non-local directories to the incluye search path so we don't require a locally compiled tesseract or leptonica 2018-04-02 17:24:47 -07:00
Shivam Kumar Jha
e507b2092b [FIX] Correct -HARDSUBX Bug In CMake (#971) 2018-04-01 13:58:43 -07:00
Saurabh Shah
d23cb8571d Fix possible segfaults in hardsubx_classifier.c due to strdup (#963)
strdup will give a segmentation fault if the argument passed to it is
NULL. TessResultIteratorGetUTF8Text returns a char* which can be NULL
and we should not call strdup directly over it. Once we check if the
value returned is not NULL, then we can call strdup.
2018-03-16 11:22:20 -07:00
Shivam Kumar Jha
b2e83ea1a6 allow build with hardsubx using cmake (#966) 2018-03-13 12:40:09 -07:00
Shivam Kumar Jha
3d6a9f4d57 [IMPROVEMENT] Add LICENSE File (#959)
* [IMPROVEMENT] Add LICENSE File

We should be adding a LICENSE File to the root of the project. We do mention that we follow GPL v2 and hence can include it's declaration file.

* Rename LICENSE to LICENSE.txt
2018-03-12 11:19:47 -07:00
Saurabh Shah
86356ba4d2 Improve the start and end timestamps of extracted burned in captions (#962)
The start and end timestamps of extracted burned in captions are flawed
and off by a large difference. Also, the start time of the first burned
in caption extracted is always zero, which is not always the case. And
the extracted captions always appear in continuous timestamps.

This commit improves the start and end timestamps of the extracted
burned in captions and reduces the error significantly, bringing the
timestamps fairly close to the actual timings as they appear in the
media file.
2018-03-12 11:19:24 -07:00
Shivam Kumar Jha
801f9e8dc8 [IMPROVEMENT] Update COMPILATION.md (#960)
Add instructions to make the installation systemwide (on Linux) which can allow CCExtractor to be used from anywhere with just the below command in terminal:
`ccextractor [videofile]`
2018-03-08 13:33:52 -08:00
Carlos Fernandez
cbcedaf2bd Fixed crash with "-out=report" and "-out=null" 2018-03-07 17:26:08 -08:00
Shivam Kumar Jha
5ada966010 [FIX]-nocf not working with OCR'ing (#958)
* Fix -nocf not working with OCR'ing

* remove dvbcolor and nodvbcolor parameter
2018-03-06 13:16:26 -08:00
Shivam Kumar Jha
587f0b8609 Display quantisation mode in info box (#954) 2018-03-06 11:35:09 -08:00
Saurabh Shah
f46e3dcfc2 Fix segfault in add_cc_sub_text and initialize to NULL in init_encoder (#950)
This commit adds some checks to avoid segmentation faults.

* In `add_cc_sub_text()`, strdup will cause a segfault if we duplicate an
  empty string.

* In `init_encoder()`, initialize pointer fields to NULL to avoid random
  addressing so we can avoid illegal memory accessing and segfaults in
  other places.
2018-03-05 13:55:01 -08:00
Carlos Fernandez
a0e7ddd632 ccx_decoders_common.c: Copy data type when creating a copy of the subtitle structure 2018-02-28 19:42:38 +00:00
Krushan Bauva
3267c68c3b [FIX] Implicit declaration of these functions throws warning during build (#948)
* Declare gf_lang_find function in isom_write.c

* Declare gf_lang_get_3cc function in isom_write.c
2018-02-28 10:51:16 -08:00
Carlos Fernandez
c829c94e54 ccx_decoders_common.c: Properly release allocated resources on free_subtitle() 2018-02-27 22:28:01 +00:00
Carlos Fernandez
39b96cc544 Added a datatype member to struct cc_subtitle - needed so we can properly free all memory when void *data points to a structure that has its own pointers. 2018-02-27 14:15:52 -08:00
Carlos Fernandez
5a79b71e70 dvb_subtitle_decoder.c: When combining image regions verify that the offset is never negative.
ts_functions.c: Added an #ifdef block to save TS packets in a temp file. Just for debug purposes.
2018-02-27 20:48:13 +00:00
Saurabh Shah
57b230e91d Add instruction required to build ccextractor with HARDSUBX support (#946)
To build ccextractor with hardsubx support on linux, we need to configure
ccextractor with the `-enable-hardsubx` switch along with the
`ENABLE_HARDSUBX` flag passed during compilation with make. This commit
adds the missing configure instruction.
2018-02-27 12:17:14 -08:00
achaudhary997
b7a2aca34e Updated traivis.yml to fix osx build (#947) 2018-02-27 11:34:26 -08:00
Manish Mahalwal
cbda2deda2 [FIX] Add utf8proc src file to cmake, updated header file (#944)
* Add utf8proc source file to cmakelists

* Update utf8proc header file

* change "utf8proc.h" to "utf8proc/utf8proc.h"
2018-02-27 10:59:20 -08:00
Carlos Fernandez
779e9c64c1 Added required pointers on freep() calls 2018-02-27 02:49:11 +00:00
Carlos Fernandez
26d488a979 - Removed dvb_debug_traces_to_stdout and used the usual dbg_print instead
- struct cc_bitmap removed data[2] and replaced with two separate variables, since they are unrelated
2018-02-26 18:29:43 -08:00
Carlos Fernandez
ef7d4a2b4b Additional debug traces for DVB
Fix minor memory leak
2018-02-27 02:07:17 +00:00
Carlos Fernandez
c6102d3b2a Fix issue with displaying utf8proc version. 2018-02-26 11:17:13 -08:00
Manish Mahalwal
4d7d4cc109 Fix failing cmake due to liblept/tesseract header files (#941) 2018-02-26 11:11:59 -08:00
Manish Mahalwal
f717624bfa [FEATURE] Added version no. of libraries to --version (#939)
* Added version no. of libraries to --version

* Fix link

* ifdef used for tesseract/leptonica

* fix spelling
2018-02-25 09:16:48 -08:00
Carlos Fernandez Sanz
2114a80dbb
Added GSoC to README.md (removed GCI) 2018-02-23 14:56:54 -08:00
Carlos Fernandez
5df3500a9f Added missing \n in params.c 2018-02-23 19:49:07 +00:00
Sourav Sahoo
393fbd30b0 [IMPROVEMENT] Corrected the tags file format of ctags in .gitignore (#908)
* Added tags file and removed the previosly wrongly writtern file

* Added .vscode to visual code section

* Added the .tags in .gitignore

* Changed *.tags to *.tags*
2018-02-23 11:36:59 -08:00
Shivam Kumar Jha
9dc1e0a9e2 Modify -quant 0 option (#932) 2018-02-23 11:34:43 -08:00
Carlos Fernandez
4875508f70 builddebug: Use -fsanitize=address -fno-omit-frame-pointer
write_dvb_sub(): Test for out of bounds and report details when this happens. Still doesn't fix the underlying issue but will help figure it out.
ocr.c: Solve malloc()/delete[] combinations that happened when operating on tesseract output. Now a malloc()'ed copy is immediately made, tesseract's results are unallocated using tesseract's delete function, and we continue using our own copy which is later free()'d.
2018-02-22 01:31:30 +00:00
Carlos Fernandez
b1c00233b3 ccx_decoders_common.c: Removed trivial memory leak.
ccx_encoders_srt.c: Made sure a pointer is non-NULL before dereferencing.
dvb_subtitle_decoder.c: Initialize pointer members to NULL when creating a structure.
lib_ccx.c: Initialize (memset 0) structure cc_subtitle after memory allocation.
README.TXT: Removed reference to sourceforge.
2018-02-21 20:31:09 +00:00
Carlos Fernandez
f85e65ba32 Updated mailing list (changed sourceforge for google groups) 2018-02-21 20:21:24 +00:00
Carlos Fernandez
150d2e7404 Add -quant (OCR quantization function) 2018-02-16 16:43:07 -08:00
Carlos Fernandez
2b997135e5 Added verboseness to error/warnings in dvb_subtitle_decoder.c 2018-02-16 14:38:54 -08:00
Carlos Fernandez
3e815ed590 Merge branch 'pr/n926_BPYap' (teletext fix)
Added verboseness to error/warnings on dvb_subtitle_decoder.c
2018-02-16 14:38:03 -08:00
Carlos Fernandez
550d3207ad Merge branch 'master' of https://github.com/CCExtractor/ccextractor 2018-02-15 22:44:11 +00:00
Carlos Fernandez
f78a1fdf95 dvb_subtitle_decoder.c: Start work on passing invalid streams errors upstream (plus some warning messages) so we can eventually recover from this situation instead of crashing.
general_loop.c: Display warning on DVB parse error. We will still crash though.
2018-02-15 22:42:23 +00:00
Yap Boon Peng
b7545e0092
Fix code indentation 2018-02-14 12:39:43 +08:00
mkver
679a69f25c Update telxcc.c (#930)
Currently setting a colour doesn't necessarily add a space even though the specifications mandate it. This commit is designed to change that.
2018-02-13 17:04:25 -08:00
Carlos Fernandez
20e439f9d8 dvb_subtitle_decoder.c: Fix null pointer derefence when region==NULL in write_dvb_sub 2018-02-13 16:43:45 -08:00
BPYap
5d3e2cdbb9 Fixing Bug #922 2018-02-14 01:16:14 +08:00
BPYap
93859297c1 Fix Bug #922
Provide checks to characters between 0xA and 0xB and set them to 0x20 while  maintaining color information
2018-02-13 20:40:24 +08:00
BPYap
2258ab23ef Fix Bug #922
Provide checks to characters between 0xA and 0xB and set them to 0x20
2018-02-13 20:31:14 +08:00
BPYap
9b0c12a1c2 Fix Bug #922 2018-02-13 18:20:23 +08:00
BPYap
8ff8443b5e Fixing Bug #922 2018-02-13 17:37:30 +08:00