Download-Tools/mkvtoolnix
1
0
Fork 0
mirror of https://gitlab.com/mbunkus/mkvtoolnix.git synced 2024-12-28 13:57:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

propedit: WebM & tags: remove unsupported elements

Browse Source 
Inspired by #2002.
This commit is contained in:
Moritz Bunkus 2017-07-22 13:28:49 +02:00
parent 16db13aa23
commit 191384fe63
3 changed files with 25 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
NEWS.md
View File

@ -22,6 +22,8 @@
* mkvmerge, mkvpropedit: added support for chapters in WebM files that is
spec-compliant by removing all tag elements not supported by the WebM
spec. Implements #2002.
* mkvpropedit: added support for tags in WebM files that is spec-compliant by
removing all tag elements not supported by the WebM spec.
## Bug fixes

26
src/propedit/tag_target.cpp
View File

@ -162,11 +162,15 @@ tag_target_c::execute() {
else
assert(false);
if (m_level1_element->ListSize()) {
mtx::tags::fix_mandatory_elements(m_level1_element);
if (!m_level1_element->CheckMandatory())
mxerror(boost::format(Y("Error parsing the tags in '%1%': some mandatory elements are missing.\n")) % m_file_name);
}
if (!m_level1_element->ListSize())
return;
mtx::tags::fix_mandatory_elements(m_level1_element);
if (!m_level1_element->CheckMandatory())
mxerror(boost::format(Y("Error parsing the tags in '%1%': some mandatory elements are missing.\n")) % m_file_name);
if (m_analyzer->is_webm())
mtx::tags::remove_elements_unsupported_by_webm(*m_level1_element);
}
void
@ -391,3 +395,15 @@ tag_target_c::has_content_been_modified()
const {
return m_tags_modified;
}
bool
tag_target_c::write_elements_set_to_default_value()
const {
return !m_analyzer->is_webm();
}
bool
tag_target_c::add_mandatory_elements_if_missing()
const {
return false;
}

2
src/propedit/tag_target.h
View File

@ -60,6 +60,8 @@ public:
virtual bool has_content_been_modified() const override;
virtual void execute() override;
virtual bool write_elements_set_to_default_value() const override;
virtual bool add_mandatory_elements_if_missing() const override;
protected:
virtual void add_or_replace_global_tags(KaxTags *tags);