From 71865d9081c2a9f65039012abd3a7ff8676d642a Mon Sep 17 00:00:00 2001
From: Moritz Bunkus <moritz@bunkus.org>
Date: Wed, 13 Feb 2019 13:35:49 +0100
Subject: [PATCH] macOS build: don't use visibility compiler flags

According to issue #2508 a self-compiled version of `mkvextract`
misbehaves if the option `-fvisibility=hidden` is used. As building my
own DMG without the option works just fine, and as the resulting
programs work fine, too, I'll simply drop both flags from the build
process altogether.

Fixes #2508.
---
 Rakefile                  | 1 -
 packaging/macos/config.sh | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/Rakefile b/Rakefile
index 213b92ff0..e5d99c1f4 100644
--- a/Rakefile
+++ b/Rakefile
@@ -145,7 +145,6 @@ def setup_globals
   cxxflags                 = "#{cflags_common} #{c(:STD_CXX)}"
   cxxflags                += " -Woverloaded-virtual" if c(:COMPILER_TYPE) != "gcc" # too many false positives in EbmlElement.h on g++ 8
   cxxflags                += " -Wnon-virtual-dtor -Wextra -Wno-missing-field-initializers #{c(:WSHADOW_COMPATIBLE_LOCAL)} #{c(:WNO_MAYBE_UNINITIALIZED)}"
-  cxxflags                += " -fvisibility=hidden -fvisibility-inlines-hidden" if $building_for[:macos]
   cxxflags                += " #{c(:QT_CFLAGS)} #{c(:BOOST_CPPFLAGS)} #{c(:USER_CXXFLAGS)}"
 
   ldflags                  = ""
diff --git a/packaging/macos/config.sh b/packaging/macos/config.sh
index bbc22501d..dc273cf94 100644
--- a/packaging/macos/config.sh
+++ b/packaging/macos/config.sh
@@ -9,7 +9,7 @@ export CPP="clang -E"
 export CXX="clang++"
 export CXXCPP="clang++ -E"
 export CFLAGS=""
-export CXXFLAGS="-std=c++14 -fvisibility=hidden -fvisibility-inlines-hidden"
+export CXXFLAGS="-std=c++14"
 export QT_CXXFLAGS="-stdlib=libc++"
 export MACOSX_DEPLOYMENT_TARGET="10.9"
 export DRAKETHREADS=${DRAKETHREADS:-4}