Download-Tools/mkvtoolnix
1
0
Fork 0
mirror of https://gitlab.com/mbunkus/mkvtoolnix.git synced 2024-12-29 06:15:24 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Windows apps: include application manifest properly

Browse Source 
The resource compiler includes identifiers that aren't defined as
preprocessor symbols verbatim as strings. Normally `RT_MANIFEST` is
defined as the integer resource 24, but if the header file where it is
defined (`winuser.h`) isn't included, the verbatim string
`RT_MANIFEST` will be used silently.

See #2415.
This commit is contained in:
Moritz Bunkus 2018-10-27 20:08:31 +02:00
parent 7e496e696d
commit afecdcc212
No known key found for this signature in database
GPG Key ID: 74AF00ADF2E32C85
6 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
NEWS.md
View File

@ -1,3 +1,11 @@
# Version ?
## Bug fixes
* MKVToolNix GUI: Windows: the application manifest is now included properly
so that Windows actually recognizes it. See #2415.
# Version 28.2.0 "The Awakening" 2018-10-25
## Bug fixes

2
src/extract/resources.rc
View File

@ -1,3 +1,5 @@
#include "winuser.h"
mkvextract ICON "../../share/icons/windows/mkvextract.ico"
#if defined(MINGW_PROCESSOR_ARCH_AMD64)

2
src/info/resources.rc
View File

@ -1,3 +1,5 @@
#include "winuser.h"
mkvinfo ICON "../../share/icons/windows/mkvinfo.ico"
#if defined(MINGW_PROCESSOR_ARCH_AMD64)

2
src/merge/resources.rc
View File

@ -1,3 +1,5 @@
#include "winuser.h"
MATROSKAICON ICON "../../share/icons/windows/mkvmerge.ico"
#if defined(MINGW_PROCESSOR_ARCH_AMD64)

2
src/mkvtoolnix-gui/resources.rc
View File

@ -1,3 +1,5 @@
#include "winuser.h"
mkvtoolnix_gui ICON "../../share/icons/windows/mkvtoolnix-gui.ico"
#if defined(MINGW_PROCESSOR_ARCH_AMD64)

2
src/propedit/resources.rc
View File

@ -1,3 +1,5 @@
#include "winuser.h"
mkvpropedit ICON "../../share/icons/windows/mkvpropedit.ico"
#if defined(MINGW_PROCESSOR_ARCH_AMD64)