Download-Tools/mkvtoolnix
1
0
Fork 0
mirror of https://gitlab.com/mbunkus/mkvtoolnix.git synced 2025-01-12 21:21:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

GUI: language init: use QHash for checking if common

Browse Source 
Microbenchmark says that using `QHash::[]` instead of
`QStringList::indexOf` is nearly four times faster. With the language
list being several thousand entries long, this does make a small
difference.
This commit is contained in:
Moritz Bunkus 2022-09-19 10:22:31 +02:00
parent 27e9bcd57e
commit cbcfa07b64
No known key found for this signature in database
GPG Key ID: 74AF00ADF2E32C85
1 changed files with 16 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
src/mkvtoolnix-gui/app.cpp
View File

@ -258,16 +258,19 @@ App::initializeIso639Languages() {
s_iso639_2Languages.reserve(mtx::iso639::g_languages.size());
s_commonIso639Languages.reserve(cfg.m_oftenUsedLanguages.size());
QHash<QString, bool> isCommon;
for (auto const &language : cfg.m_oftenUsedLanguages)
isCommon[language] = true;
for (auto const &language : mtx::iso639::g_languages) {
auto languageCode = Q(language.alpha_3_code);
auto languageCodes = language.alpha_2_code.empty() ? languageCode : Q("%1; %2").arg(Q(language.alpha_2_code)).arg(languageCode);
auto description = Q("%1 (%2)").arg(Q(gettext(language.english_name.c_str()))).arg(languageCodes);
auto isCommon = cfg.m_oftenUsedLanguages.indexOf(languageCode) != -1;
s_iso639Languages.emplace_back(description, languageCode);
if (language.is_part_of_iso639_2)
s_iso639_2Languages.emplace_back(description, languageCode);
if (isCommon)
if (isCommon[languageCode])
s_commonIso639Languages.emplace_back(description, languageCode);
s_iso639_2LanguageCodeToDescription[languageCode] = description;
@ -283,15 +286,18 @@ App::initializeRegions() {
auto &cfg = Util::Settings::get();
s_regions.reserve(mtx::iso3166::g_regions.size());
s_commonRegions.reserve(mtx::iso3166::g_regions.size());
s_commonRegions.reserve(cfg.m_oftenUsedRegions.size());
QHash<QString, bool> isCommon;
for (auto const &region : cfg.m_oftenUsedRegions)
isCommon[region] = true;
for (auto const &region : mtx::iso3166::g_regions) {
auto countryCode = !region.alpha_2_code.empty() ? Q(region.alpha_2_code).toLower() : Q(fmt::format("{0:03}", region.number));
auto description = formatRegionDescription(region);
auto isCommon = cfg.m_oftenUsedRegions.indexOf(countryCode) != -1;
s_regions.emplace_back(description, countryCode);
if (isCommon)
if (isCommon[countryCode])
s_commonRegions.emplace_back(description, countryCode);
s_regionToDescription[countryCode] = description;
@ -308,11 +314,15 @@ App::initializeCharacterSets() {
s_characterSets.reserve(g_character_sets.size());
s_commonCharacterSets.reserve(cfg.m_oftenUsedCharacterSets.size());
QHash<QString, bool> isCommon;
for (auto const &characterSet : cfg.m_oftenUsedCharacterSets)
isCommon[characterSet] = true;
for (auto const &characterSet : g_character_sets) {
auto qCharacterSet = Q(characterSet);
s_characterSets.emplace_back(qCharacterSet);
if (cfg.m_oftenUsedCharacterSets.contains(qCharacterSet))
if (isCommon[qCharacterSet])
s_commonCharacterSets.emplace_back(qCharacterSet);
}