Download-Tools/mkvtoolnix
1
0
Fork 0
mirror of https://gitlab.com/mbunkus/mkvtoolnix.git synced 2024-10-22 07:21:21 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

macOS build: don't use visibility compiler flags

Browse Source 
According to issue #2508 a self-compiled version of `mkvextract`
misbehaves if the option `-fvisibility=hidden` is used. As building my
own DMG without the option works just fine, and as the resulting
programs work fine, too, I'll simply drop both flags from the build
process altogether.

Fixes #2508.
This commit is contained in:
Moritz Bunkus 2019-02-13 13:35:49 +01:00
parent ac30bb5a04
commit 71865d9081
No known key found for this signature in database
GPG Key ID: 74AF00ADF2E32C85
2 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
Rakefile
View File

@ -145,7 +145,6 @@ def setup_globals
cxxflags = "#{cflags_common} #{c(:STD_CXX)}"
cxxflags += " -Woverloaded-virtual" if c(:COMPILER_TYPE) != "gcc" # too many false positives in EbmlElement.h on g++ 8
cxxflags += " -Wnon-virtual-dtor -Wextra -Wno-missing-field-initializers #{c(:WSHADOW_COMPATIBLE_LOCAL)} #{c(:WNO_MAYBE_UNINITIALIZED)}"
cxxflags += " -fvisibility=hidden -fvisibility-inlines-hidden" if $building_for[:macos]
cxxflags += " #{c(:QT_CFLAGS)} #{c(:BOOST_CPPFLAGS)} #{c(:USER_CXXFLAGS)}"
ldflags = ""

2
packaging/macos/config.sh
View File

@ -9,7 +9,7 @@ export CPP="clang -E"
export CXX="clang++"
export CXXCPP="clang++ -E"
export CFLAGS=""
export CXXFLAGS="-std=c++14 -fvisibility=hidden -fvisibility-inlines-hidden"
export CXXFLAGS="-std=c++14"
export QT_CXXFLAGS="-stdlib=libc++"
export MACOSX_DEPLOYMENT_TARGET="10.9"
export DRAKETHREADS=${DRAKETHREADS:-4}